Fix that the SA1119 code fix can produce invalid syntax.#450
Closed
pdelvo wants to merge 1 commit intoDotNetAnalyzers:masterfrom
Closed
Fix that the SA1119 code fix can produce invalid syntax.#450pdelvo wants to merge 1 commit intoDotNetAnalyzers:masterfrom
pdelvo wants to merge 1 commit intoDotNetAnalyzers:masterfrom
Conversation
If the opening parenthesis does not have leading trivia in some cases the code fix would merge the leading node (token) and the syntax node (token) in the parenthesis creating invalid syntax.
Member
Author
|
Weird that the test failed. It works on my machine. |
Member
|
We need a way to check the fix all provider here too. Any ideas? |
This was referenced Feb 6, 2015
Member
|
Superseded by #453 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the opening parenthesis does not have leading trivia in some cases the code fix would merge the leading node (token) and the syntax node (token) in the parenthesis creating invalid syntax.
Fixes #449