Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: Permanently disable rule SA1109 #998

Closed
sharwell opened this issue Jul 18, 2015 · 3 comments
Closed

Proposal: Permanently disable rule SA1109 #998

sharwell opened this issue Jul 18, 2015 · 3 comments
Assignees
Milestone

Comments

@sharwell
Copy link
Member

All violations of rule SA1109 (BlockStatementsMustNotContainEmbeddedRegions) are also violations of rule SA1123 (DoNotPlaceRegionsWithinElements). I propose disabling SA1109 the same way we disabled SA1126 (in #997) for the following reasons:

  1. Rule SA1109 is a subset of another rule; disabling the rule still leaves users with a warning and a code fix for less computational work.
  2. Violations of SA1109 are rare; special-casing this rule is unlikely to ever provide significant benefits to users.
@Noryoko
Copy link
Contributor

Noryoko commented Jul 26, 2015

👍

2 similar comments
@pdelvo
Copy link
Member

pdelvo commented Jul 26, 2015

👍

@JohanLarsson
Copy link

👍

@sharwell sharwell added this to the 1.0.0 Beta 2 milestone Jul 26, 2015
@sharwell sharwell self-assigned this Jul 26, 2015
sharwell added a commit to sharwell/StyleCopAnalyzers that referenced this issue Jul 26, 2015
@sharwell sharwell added the fixed label Jul 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants