Repository navigation
Pin Redoc to v2 in generated API docs - #1288
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
Contributor
Author
|
Thank you for merging this, Donkie. Pinning Redoc to v2 should keep the generated API docs rendering until the v3 bundle works in a classic script tag. Happy to follow up if you would like the version bumped differently. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for the clear console output in the report, it made this quick to trace.
generate_docs()inspoolman/docs.pyloads Redoc from the unversionedcdn.jsdelivr.net/npm/redocURL.jsDelivr now resolves that to Redoc 3.0.1, whose standalone bundle contains
import.meta.That is a SyntaxError in a classic
<script>tag, so the bundle never runs andRedoc.initfails withRedoc is not defined.This pins the script to
[email protected], the latest v2 release, whose standalone bundle has noimport.meta.I regenerated the docs with
generate_docs()and checked thatindex.htmlnow points at the pinned bundle, and ruff is clean.Fixes #1287