-
Notifications
You must be signed in to change notification settings - Fork 1.6k
CodeLens for Shebangs #1267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CodeLens for Shebangs #1267
Conversation
58def33 to
4bd97b2
Compare
|
@Kavakuo |
…ature#shebangDetection
|
@Kavakuo let me know if you need a hand with the unit tests. |
|
I think I made it 👍 I hope these tests are ok and the files I added are in the right place. |
|
@DonJayamanne Everything fixed. Travis also passes 👍 |
|
@Kavakuo , please could you use |
|
@DonJayamanne
|
|
@Kavakuo thanks for the PR. |
|
@DonJayamanne |
|
One thing I just realized is what happens if someone uses |
|
Oh well, I think that won't work currently. Totally overseen this, because I usually use absolute paths. The extension would want to set I think the best solution is to build something that resolves the raw Can look into this tomorrow. If you have other solution ideas or want to build this yourself, let me know. Should we open a new issue for this? |
|
Yeah, an issue would be good and I have no specific suggestions on how best to handle it. |
|
I can fix that, basically i just evaluate the expression and get the path out of that. |
This implements #1261 and works best in combination with #1263 (otherwise clicking the CodeLens without an error is only possible with an opened workspace).
The CodeLens is only visible when the current selected interpreter is another than the interpreter specified in the shebang. Clicking the CodeLens changes the interpreter and after that the CodeLens disappears.