Skip to content

chore(docker): bump Node base image, pnpm and pack to pick up security fixes - #5737

Closed
erwannbst wants to merge 1 commit into
Dokploy:canaryfrom
erwannbst:chore/bump-image-toolchain-cves
Closed

erwannbst wants to merge 1 commit into
Dokploy:canaryfrom
erwannbst:chore/bump-image-toolchain-cves

Conversation

@erwannbst

@erwannbst erwannbst commented Oct 22, 2026 •

Copy link
Copy Markdown

What is this PR about?

Bumps the pinned tooling in the Dokploy image so the published image stops shipping known, already-fixed HIGH/CRITICAL CVEs (see #5736):

  • Base image node:24.4.0-slim → node:24.22.1-bookworm-slim. Picks up the Node.js 24 security releases since July 2025 and refreshed Debian 12 packages (12.11 → 12.15: libgnutls30, libpam*, libpcre2-8-0, gpgv, git-lfs). I pinned -bookworm explicitly so the distro stays the same, because the plain -slim tag now resolves to trixie.
  • pnpm 10.22.0 → 10.34.7 (corepack in all Dockerfiles, packageManager fields, CI pnpm/action-setup). The copy that ships in the runtime image had 14 HIGH advisories. Same lockfile format, so pnpm install --frozen-lockfile works unchanged.
  • pack buildpacksio/pack:0.39.1 → 0.40.10 (Go stdlib, x/crypto, go-git, buildkit, kaniko).
  • .nvmrc, CI node-version and CONTRIBUTING.md are kept in sync with the new Node version. engines (^24.4.0) is left alone, since it's a lower bound.

Railpack (0.15.4) and Docker (28.5.2) are left out on purpose. Bumping them changes build behaviour and Docker API compatibility, so they deserve their own discussion.

Trivy results (HIGH/CRITICAL, fixable only, unique findings)

dokploy/dokploy:canary (2026-10-16) this PR
OS (Debian) 17 (12.11) 0 (12.15)
pnpm 14 0
pack 55 0
node packages 87 48
railpack / docker binaries (unchanged) 59 / 186 59 / 178
Total CRITICAL 14 / HIGH 405 CRITICAL 8 / HIGH 278

How it was tested

  • docker build . succeeds (after cp apps/dokploy/.env.production.example .env.production, as CI does).
  • I ran the image against a fresh postgres:16 and redis:7 on an isolated network. Migrations ran, workers started, /api/trpc/settings.health returned 200 in about 15s, and / redirected to /register (200).
  • Versions inside the container: node v24.22.1, pnpm 10.34.7, pack 0.40.10, railpack 0.15.4, Docker 28.5.2.

Checklist

Issues related (if applicable)

Refs #5736. This covers the image/tooling part of that issue. The other part (shipping #5517 / Next.js 16.3.8 in a stable release) needs a release from canary.

🤖 Generated with Claude Code

RetriggerView in GreptileConfidence Score: 5/5

This PR appears safe to merge; no blocking issues were found.

Summary

Updates the tooling pinned in Dokploy images.

  • Dokploy images use newer Node, pnpm, and pack versions.
  • CI and local setup use the same pinned Node and pnpm versions.

Reviews (1) · Last reviewed commit: "chore(docker): bump Node base image, pnp..." · Reviewed by Greptile

…y fixes

- node:24.4.0-slim -> node:24.22.1-bookworm-slim (Node.js security
  releases + refreshed Debian 12 packages: gnutls, pam, pcre2, gpgv, git-lfs)
- pnpm 10.22.0 -> 10.34.7 (14 HIGH advisories in the copy shipped in the image)
- buildpacksio/pack 0.39.1 -> 0.40.10 (Go stdlib, x/crypto, go-git, buildkit)

Keeps .nvmrc, CI workflows, packageManager fields and CONTRIBUTING in sync.

Refs Dokploy#5736

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@imrja8

imrja8 commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator

Thanks @erwannbst for this and for the detailed Trivy breakdown in #5736! The Node.js 24.22.1 base image bump is shipped from the Dokploy team in #5738, so we're closing this one in favor of it. Package and version bumps are handled separately by team, so we're keeping them out of this security fix. Really appreciate the help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants