Repository navigation
fix: preserve application status when saving provider settings - #5455
Merged
narcisonunez merged 2 commits intoSep 29, 2026
Merged
narcisonunez merged 2 commits into
narcisonunez merged 2 commits into
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
narcisonunez
approved these changes
Sep 29, 2026
Collaborator
|
@roshanasingh4 Please, send a PR doing the same thing for compose if possible, Thanks |
2 of 3 tasks
Contributor
Author
|
@narcisonunez Done — I opened #5544 with the same status-preservation fix for Compose provider saves and disconnects, including regression coverage for all five provider forms and both |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
Saving provider settings on an existing application currently changes its stored status to
idle. For example, editing GitHub watch paths makes a running application show a gray status dot and a Start button even though its container is still running. Provider settings do not start or stop the service, so these save handlers now leave application status unchanged.Validation
doneandrunningstatuses.