Repository navigation
test: fix CI failures and improve test robustness - #5271
Merged
Merged
Conversation
narcisonunez
approved these changes
Sep 2, 2026
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses two separate testing issues that are currently causing friction in
canary:Fix fatal CI failure in
application.real.test.ts(Regression from fix/docker-context-path-default: Placeholder with name attribute "doc… #5231)The recent change in
getDockerContextPathforced a fallback to.instead of returningnull. This brokedocker-file.ts, which relied on thenullreturn to accurately infer thedefaultContextPathfrom the Dockerfile's parent directory. Because of this, Docker builds in the test suite started failing in CI as they were given an invalid context path. This restores thenullreturn and the correct fallback logic.Fix
ENOENT /var/run/docker.sockcrashes for local contributors (fix(monitoring): remove legacy container and default empty cronJob #5141, fix: preserve ${VAR} interpolation in .env values #5197)Tests like
monitoring-setup.real.test.tsandenv-file-literals.test.tsrequire a running Docker daemon. When contributors (especially those on macOS using Colima/Orbstack or without Docker running) runpnpm testlocally, the entire test suite crashes with socket errors. I've added a simplehasDocker()check so these tests gracefully skip locally instead of crashing, while still running properly in CI.Greptile Summary
This PR restores Dockerfile build-context fallback behavior and makes Docker-dependent tests skip when their required local daemon is unavailable.
nullfromgetDockerContextPathfor an omitted context.Confidence Score: 5/5
The PR appears safe to merge, with no concrete blocking or non-blocking defects identified.
The Docker builder once again distinguishes an omitted context from an explicitly configured one, while the integration-test guards prevent unavailable local Docker daemons from crashing the suite without weakening the configured CI path.
Reviews (1): Last reviewed commit: "test: fix CI failures and improve local ..." | Re-trigger Greptile
Context used: