Skip to content

fix/docker-context-path-default: Placeholder with name attribute "doc… - #5231

Merged
Siumauricio merged 1 commit into
Dokploy:canaryfrom
drago1520:fix/docker-context-path-default
Sep 2, 2026
Merged

Siumauricio merged 1 commit into
Dokploy:canaryfrom
drago1520:fix/docker-context-path-default

Conversation

@drago1520

@drago1520 drago1520 commented Aug 31, 2026 •

Copy link
Copy Markdown
Contributor

…kerContextPath" lied that the default path is ".", while being the Dockerfile directory.

What is this PR about?

Docker context path input UI lies.

Please describe in a short paragraph what this PR is about.
image
while it's actually the Dockerfile directory as context by default.

Checklist

Before submitting this PR, please make sure that:

Issues related (if applicable)

Screenshots (if applicable)

It's my first PR here :)

Greptile Summary

This PR aligns the Dockerfile build behavior with the Docker context input’s documented default by resolving an unset context path to the application’s code root.

  • Makes getDockerContextPath always return an absolute workspace path, defaulting to . beneath the code directory.
  • Removes the Dockerfile-directory fallback from Docker command generation.

Confidence Score: 5/5

The PR appears safe to merge, with no actionable correctness or security issues identified.

The changed resolver and Docker command remain aligned: an unset context now resolves to the application code root, while explicitly configured context paths continue to resolve beneath the same workspace.

Reviews (1): Last reviewed commit: "fix/docker-context-path-default: Placeho..." | Re-trigger Greptile

…kerContextPath" lied that the default path is ".", while being the Dockerfile directory.
@drago1520
drago1520 requested a review from Siumauricio as a code owner August 31, 2026 06:41
@Siumauricio
Siumauricio merged commit e67d9ef into Dokploy:canary Sep 2, 2026
3 of 5 checks passed
@imrja8

imrja8 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

Hey @drago1520, just a heads-up that this PR seems to have broken the CI tests on canary for everyone else.

The change made in getDockerContextPath (returning dockerContextPath || "." instead of null when it's empty) breaks the application.real.test.ts test in GitHub Actions. Because of this hardcoded fallback, the Nixpacks builder in the test tries to build against an invalid absolute path and instantly crashes with ❌ Nixpacks build failed.

Could you take a look at either reverting that specific fallback or updating the test so the CI pnpm test job passes again?

@nikodunk

nikodunk commented Sep 4, 2026

Copy link
Copy Markdown

For those of you confused as to why your Docker builds are suddenly breaking since the newest update like me with:

ERROR: failed to calculate checksum of ref hash: "xzy file": not found

You now need to copy your custom build path subfolder

image

To here:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants