You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
S3 credentials are logged in plaintext again: redactRcloneCredentials stopped matching after the shell-quote change #5519
Expected: the access key and secret are redacted, as #4648 intended when it fixed #4621.
Current: both are logged in plaintext on every backup run. Anyone who can read the Dokploy service logs, or wherever they are shipped, gets full access to the backup bucket. That is read and delete access to every database backup stored there.
Cause:redactRcloneCredentials() (packages/server/src/utils/backups/redact.ts) only matches double-quoted values:
quote() leaves a value bare when it has no special characters, so the flags come out unquoted, as --s3-secret-access-key=K001..., and the redaction regex never matches.
The tests in apps/dokploy/__test__/backups/redact-credentials.test.ts build hand-written double-quoted command strings instead of calling getS3Credentials(), so they kept passing after the format changed.
Provide environment information
Operating System:
OS: Ubuntu 24.04.4 LTS
Arch: x86_64
Dokploy version: v0.30.7 (still present on canary as of a0e0574bc)
Docker: 29.6.2
VPS Provider: self-hosted (Incus instance on a dedicated server)
What applications/services are you trying to deploy?
Postgres database with a scheduled S3 backup (Backblaze B2)
Which area(s) are affected? (Select all that apply)
Databases
Are you deploying the applications where Dokploy is installed or on a remote server?
Same server where Dokploy is installed
Additional context
#4951 fixed this: it redacts unquoted, single-quoted and space-separated forms, and tests against output from getS3Credentials(), so the next change to quoting breaks the test instead of silently leaking. Its description says the same credentials also reach notifications, API error responses and the restore stream in the UI. It was a draft and was closed on Sep 11 without review.
Activity
linear-code commentedon Sep 24, 2026
DOK-800
Souvik-Cyclic commentedon Sep 26, 2026
Opened #5527 to fix this: the redaction regex from #4648 stopped matching after #4873 switched these flags to shell-quote.