Remove/destroy the NDI filter sender when source is removed#1457
Merged
Conversation
Co-authored-by: Copilot <[email protected]>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #1407 by ensuring the NDI sender associated with the “Dedicated NDI Output” filter is torn down when the filter is removed (including when its parent source is deleted), not only when OBS shuts down.
Changes:
- Added a
filter_removecallback to destroy the NDI sender when the filter is removed from its parent. - Refactored rename signal handler disconnection into a shared helper to reuse across destroy/remove paths.
- Unified sender teardown by routing destruction through
ndi_sender_destroy().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
This use case fails to destroy the filter:
I believe this is a because of the OBS API not calling filter_remove while there is a filter dialog open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uniformise the destroy process for video & audio filter
Call the filter_remove when a filter is actually removed (or parent is deleted)
Resolving this will address and close #1407