Fix case-insensitive registry display name check in Windows installer for DistroAV and OBS-NDI by Copilot · Pull Request #1448 · DistroAV/DistroAV

Copilot · 2026-04-22T20:51:55Z

Change both Pos('DistroAV', DisplayNameRegistry) calls to case-insensitive checks using LowerCase()
Also check for obs-ndi (old plugin name) in addition to distroav in both HKLM and HKCU registry checks
Consolidate duplicate display name check into reusable IsDisplayNameDistroAvOrObsNdi() helper function

…er script Agent-Logs-Url: https://github.com/DistroAV/DistroAV/sessions/f69022db-9466-4014-996c-134047a3f6c7 Co-authored-by: paulpv <[email protected]>

paulpv

@copilot test for both "obs-ndi" and "distroav", not just "distroav"

…ive) Agent-Logs-Url: https://github.com/DistroAV/DistroAV/sessions/86a7b55f-887a-4a6b-a5ac-2ea953371abc Co-authored-by: paulpv <[email protected]>

Copilot · 2026-04-22T20:53:59Z

@copilot test for both "obs-ndi" and "distroav", not just "distroav"

Done in fa34c95. Both HKLM and HKCU checks now test for either 'distroav' or 'obs-ndi' (case-insensitively) in the DisplayName registry value.

paulpv

@copilot Consolidate duplicate if ( (Pos('distroav', LowerCase(DisplayNameRegistry)) > 0) or (Pos('obs-ndi', LowerCase(DisplayNameRegistry)) > 0) ) into a reusable function

… function Agent-Logs-Url: https://github.com/DistroAV/DistroAV/sessions/25fd3737-de86-42ab-bc1a-25f65b271862 Co-authored-by: paulpv <[email protected]>

Copilot · 2026-04-22T20:58:18Z

@copilot Consolidate duplicate if ( (Pos('distroav', LowerCase(DisplayNameRegistry)) > 0) or (Pos('obs-ndi', LowerCase(DisplayNameRegistry)) > 0) ) into a reusable function

Done in a3eb400. Extracted the check into IsDistroAVOrObsNdiDisplayName(DisplayName: String): Boolean which both HKLM and HKCU branches now call.

Agent-Logs-Url: https://github.com/DistroAV/DistroAV/sessions/28bd2621-a156-471f-83c6-d9afe48f582d Co-authored-by: paulpv <[email protected]>

Copilot

Pull request overview

Updates the Inno Setup Windows installer logic to more reliably detect and uninstall legacy DistroAV/OBS-NDI installs by making the registry DisplayName checks case-insensitive and recognizing both the current and historical plugin names.

Changes:

Add IsDistroAVOrObsNdiDisplayName() helper to centralize display-name detection logic.
Switch the {}_is1 (6.1.0) uninstall gating logic from case-sensitive Pos('DistroAV', ...) to case-insensitive checks.
Expand the accepted display-name substrings to include both distroav and obs-ndi.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

paulpv

@Trouffman @RayneYoruka @BitRate27 This PR's code looks fine now, but I think we are still trying to figure out why Rayne is weirdly seeing some plugin(s) still uninstall. :/

Copilot AI assigned Copilot and paulpv Apr 22, 2026

Copilot created this pull request from a session on behalf of paulpv April 22, 2026 20:51 View session

paulpv requested changes Apr 22, 2026

View reviewed changes

Copilot started work on behalf of paulpv April 22, 2026 20:53 View session

Copilot AI changed the title ~~Fix case-insensitive DistroAV registry display name check in Windows installer~~ Fix case-insensitive registry display name check in Windows installer for DistroAV and OBS-NDI Apr 22, 2026

Copilot finished work on behalf of paulpv April 22, 2026 20:54

Copilot AI requested a review from paulpv April 22, 2026 20:54

Merge branch 'master' into copilot/fix-case-insensitive-tests

a0e53eb

paulpv requested changes Apr 22, 2026

View reviewed changes

Copilot started work on behalf of paulpv April 22, 2026 20:57 View session

Copilot finished work on behalf of paulpv April 22, 2026 20:59

Copilot AI requested a review from paulpv April 22, 2026 20:59

paulpv marked this pull request as ready for review April 22, 2026 20:59

Copilot AI review requested due to automatic review settings April 22, 2026 20:59

Copilot started reviewing on behalf of paulpv April 22, 2026 20:59 View session

paulpv requested changes Apr 22, 2026

View reviewed changes

Comment thread cmake/windows/resources/installer-Windows.iss.in Outdated

Copilot started work on behalf of paulpv April 22, 2026 21:00 View session

Rename IsDistroAVOrObsNdiDisplayName to IsDisplayNameDistroAvOrObsNdi

febb1af

Agent-Logs-Url: https://github.com/DistroAV/DistroAV/sessions/28bd2621-a156-471f-83c6-d9afe48f582d Co-authored-by: paulpv <[email protected]>

Copilot AI reviewed Apr 22, 2026

View reviewed changes

Comment thread cmake/windows/resources/installer-Windows.iss.in Outdated

Copilot finished work on behalf of paulpv April 22, 2026 21:02

Copilot AI requested a review from paulpv April 22, 2026 21:02

Potential fix for pull request finding

5f51e69

Co-authored-by: Copilot Autofix powered by AI <[email protected]>

This comment was marked as duplicate.

Sign in to view

paulpv approved these changes Apr 22, 2026

View reviewed changes

Trouffman self-requested a review April 22, 2026 21:11

Trouffman approved these changes Apr 22, 2026

View reviewed changes

paulpv merged commit a34ff5e into master Apr 22, 2026
9 checks passed

paulpv deleted the copilot/fix-case-insensitive-tests branch April 22, 2026 21:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Fix case-insensitive registry display name check in Windows installer for DistroAV and OBS-NDI#1448

Fix case-insensitive registry display name check in Windows installer for DistroAV and OBS-NDI#1448
paulpv merged 6 commits into
masterfrom
copilot/fix-case-insensitive-tests

Copilot AI commented Apr 22, 2026 •

edited

Loading

Uh oh!

paulpv left a comment

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

paulpv left a comment

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

paulpv left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Uh oh!

Uh oh!

Conversation

Copilot AI commented Apr 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

paulpv left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

paulpv left a comment

Choose a reason for hiding this comment

Uh oh!

Copilot AI commented Apr 22, 2026

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

This comment was marked as duplicate.

Uh oh!

paulpv left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Apr 22, 2026 •

edited

Loading