Fix installer blindly uninstalling any app registered under {}_is1 registry key#1442
Merged
Merged
Conversation
8 tasks
…void uninstalling other apps Agent-Logs-Url: https://github.com/DistroAV/DistroAV/sessions/87282a2c-f06c-43db-b2cd-a8adb9524c93 Co-authored-by: paulpv <[email protected]>
Copilot
AI
changed the title
[WIP] Fix DistroAV causing uninstall of OBS plugins
Fix installer blindly uninstalling any app registered under Apr 21, 2026
{}_is1 registry key
paulpv
marked this pull request as ready for review
April 21, 2026 18:12
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the Windows installer cleanup logic to prevent accidentally uninstalling unrelated OBS plugins that happen to be registered under the broken Inno Setup uninstall key Software\Microsoft\Windows\CurrentVersion\Uninstall\{}_is1 left behind by DistroAV 6.1.0.
Changes:
- Update
Get610AppUninstallerPathto additionally validateDisplayNamecontainsDistroAVbefore returning the uninstaller path. - Apply the same
DisplayNameguard for bothHKLMandHKCUuninstall registry locations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Note : this cannot be tested anymore as we did remove the 6.1.0 installer as this was a known issue on release. 6.1.0 is expected to impact ~600 users today. |
Trouffman
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DistroAV 6.1.0's broken installer registered under the empty-GUID key
{}_is1. The cleanup code in subsequent installers matched and uninstalled any app sharing that key — including unrelated OBS plugins like StreamUP, DownstreamKeyer, and SceneAsTransition.Change
Get610AppUninstallerPath: Now validatesDisplayNamecontains"DistroAV"before returning the uninstaller path, for bothHKLMandHKCUlocations.As shown in the screenshot,
{}_is1can be owned by an entirely different app (e.g. StreamUP withDisplayName = "streamup version 2.2.2"). The guard ensures only the legitimate DistroAV 6.1.0 remnant is removed.