Skip to content

Remove Visual Studio generator from presets#1439

Merged
Trouffman merged 2 commits into
masterfrom
ci-vs-studio
Apr 21, 2026
Merged

Remove Visual Studio generator from presets#1439
Trouffman merged 2 commits into
masterfrom
ci-vs-studio

Conversation

@Trouffman

@Trouffman Trouffman commented Apr 21, 2026

Copy link
Copy Markdown
Collaborator

Remove the hard requirement for Visual Studio 17 (VS 2022) and allow to build using Visual Studio 18 (2026)

Should address the error below when using Visual Studio 18 2026

[cmake] CMake Error at CMakeLists.txt:5 (project):
[cmake]   Generator
[cmake] 
[cmake]     Visual Studio 17 2022
[cmake] 
[cmake]   could not find any instance of Visual Studio.
[cmake] 
[cmake] 
[cmake] 
[cmake] -- Configuring incomplete, errors occurred!

Remove the hard requirement for Visual Studio 17 (VS 2022) and allow to build using Visual Studio 18 (2026)
@paulpv
paulpv self-requested a review April 21, 2026 19:22

@paulpv paulpv left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Trouffman If you say this works then you have my approval

@Trouffman
Trouffman merged commit c0ff01f into master Apr 21, 2026
9 checks passed
@Trouffman
Trouffman deleted the ci-vs-studio branch April 21, 2026 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants