Default NDI name for filters to be <filter> (<source>)#1412
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the NDI dedicated output filter so its default NDI stream name is unique by default (based on filter + source name), and keeps existing saved collections working by using placeholder expansion at runtime.
Changes:
- Set the en-US default NDI filter name to
"<filter> (<source>)"and remove the localized default keys from other locales. - Expand
<filter>/<source>placeholders when creating the NDI sender and recreate the sender on rename events. - Attempt to lazily create the sender during
ndi_filter_tickwhen it wasn’t created earlier (e.g., missing parent).
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| src/ndi-filter.cpp | Adds placeholder expansion and rename-driven sender recreation for unique default filter NDI names. |
| data/locale/en-US.ini | Changes default filter NDI name string to "<filter> (<source>)". |
| data/locale/ca-ES.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/de-DE.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/es-ES.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/fr-FR.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/hu-HU.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/ko-KR.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/nl-NL.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/pt-BR.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/ro-RO.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/sv-SE.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/uk-UA.ini | Removes localized default key for filter NDI name (relies on fallback). |
| data/locale/zh-CN.ini | Removes localized default key for filter NDI name (relies on fallback). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Trouffman
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes issue 1302 requesting default for NDI names be unique.
To do this we look for
<filter>and<source>in the NDI name field and replace with the appropriate string from OBS. We also set the Default for NDI names for Filters to be"<filter> (<source>)"in en-US so that we continue to support existing names in saved collections. One caveat is we had to remove the NDIPlugin.FilterProps.NDIName.Default from the other locale files as this would require the tests to be language dependent.This keeps the names unique as there are no duplicated filter names in a source and no duplicated source names in a OBS collection.