Fix filter-chain rendering, Part 2#1380
Merged
Merged
Conversation
Use `obs_source_showing` instead of `obs_source_active` to ensure the filter is valid (to allow rendering / sending in the OBS Preview for example)
This was leftover from when the NDI sender was destroyed when the source of the filter was hidden / invalid. The new logic keeps it active at all times, but doesn't send new data over when it doesn't call the render functions.
This extra check ensures we only render and send the video data once and not multiple times (e.g. when the source is active in an OBS window, such as the Preview, and then opening the Properties for the source, which will cause it to have frames sent out of order / causing it to seem like it stutters)
BitRate27
approved these changes
Nov 30, 2025
BitRate27
left a comment
Contributor
There was a problem hiding this comment.
Verified the filter works when the source is in the previewed scene.
Verified the NDI source will clear 3sec after empty frame received.
Verified the sender isn't trying to be recreated in the tick loop when the sender create fails.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes up some issues that were missed with the first PR in #1343
obs_source_activeit now checks forobs_source_showingto ensure the filter is validndi_filter_tickmethodrenderedboolean checkScreen.Recording.2025-11-28.125332.mp4