Update-Process - Change the way the GUID is expected to exist#1349
Conversation
|
The process now only "read" the Install GUID from OBS "General". If no GUID is detected (meaning that OBS is launched for the first time) this will returned a dummy identifiable GUID (needed for the update process) This is set to 
This is also managed in the log entries to be easier to debug : This uses the OBS GUID as soon as it exists (aka when a "save" event occurs.) |
|
@paulpv please review this change as it update the behavior you initially put in place. |
|
Note : |
1 participant
This PR should address the challenge set on #1171
This would effectively read the GUID set by OBS and never write it.
We will need a way to detect a new "install" maybe with a placeholder value for the update check.
This is because on a FIRST clean OBS launch, the GUID does not exist until there is a "save" event in OBS (settings change or OBS close).
This means that when loading the plugin, that GUID does not exist yet.
The Plugin should never write this because :
This can be addressed by :
A. Only read the GUID if it exists, use a fallback & identifiable value if not.
B. Create our own GUID in our own config space.
This PR implement option A.