Skip to content

Add random number to NDI test name#1332

Merged
Trouffman merged 1 commit into
DistroAV:masterfrom
BitRate27:fixduptestnames
Aug 17, 2025
Merged

Add random number to NDI test name#1332
Trouffman merged 1 commit into
DistroAV:masterfrom
BitRate27:fixduptestnames

Conversation

@BitRate27

Copy link
Copy Markdown
Contributor

When starting multiple OBS Studio instances at the same time, the creation of an NDI sender for testing for supported pixel format can fail if there is already a sender with the same name created. This PR adds a 5 digit random number to the name "NDI Output Support Test", so that every name is unique.

This is to address issue 1326 where the Main Output is disabled. This was because of "invalid format", but in reality the sender was not able to be created as the name already was being used by another instance of OBS.

I tested this change in the same scenario as the one in issue 1326: 4 portable instances launched at the same time in Task Scheduler. I confirmed all main outputs were started and log files were clean of Errors and Warnings.

Also in this PR is NOT turning off the Main Output in the config saved for the user. This does not change the behavior for the original case where a user has chosen an unsupported output format.

This was tested by:

  1. Toggling off the main output, changing the pixel format, and then not being able to turn on main output.
  2. With main output turned on, loaded a profile with an invalid pixel format and it did not crash. When bringing up the output dialog, the main output was still turned on, but the container was not enabled and not outputting main.
  3. When choosing a profile with a supported pixel format, the main output restarted as it was still turned on.

Note: Previous branch used for previous PR to address this issue got corrupted. This PR includes changes suggested by @paulpv and @Trouffman in that PR.

@Trouffman
Trouffman merged commit b53afba into DistroAV:master Aug 17, 2025
6 checks passed
@BitRate27

BitRate27 commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author
ey, I appreciate your help
I don't believe I had/have multiple instances of OBS running. If I were to open another instance, I am met with the warning popup.
Is it possible that something else is causing the conflict?

Either way, the build you provided did resolve the setting issue, and I can close and reopen OBS to my heart's content without re-checking that box for the time being.
Thank you! (edited)

Had a user verify the change works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants