Add random number to NDI test name#1332
Merged
Merged
Conversation
Trouffman
approved these changes
Aug 17, 2025
Contributor
Author
Had a user verify the change works. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When starting multiple OBS Studio instances at the same time, the creation of an NDI sender for testing for supported pixel format can fail if there is already a sender with the same name created. This PR adds a 5 digit random number to the name "NDI Output Support Test", so that every name is unique.
This is to address issue 1326 where the Main Output is disabled. This was because of "invalid format", but in reality the sender was not able to be created as the name already was being used by another instance of OBS.
I tested this change in the same scenario as the one in issue 1326: 4 portable instances launched at the same time in Task Scheduler. I confirmed all main outputs were started and log files were clean of Errors and Warnings.
Also in this PR is NOT turning off the Main Output in the config saved for the user. This does not change the behavior for the original case where a user has chosen an unsupported output format.
This was tested by:
Note: Previous branch used for previous PR to address this issue got corrupted. This PR includes changes suggested by @paulpv and @Trouffman in that PR.