Update Linux Installer Script#1304
Conversation
update package creator to use NDI 6.2
|
This will also look for the libndi files in an additional location to help with the Flakpak release at https://github.com/flathub/com.obsproject.Studio.Plugin.DistroAV Once released the following code can be removed from the Flatpak process: |
Trouffman
added
ci
linux (supported)
linux (unsupported)
Installation
|
For the record and the changes to add the flatpak path to the detection logic: From a Discord discussion with tytan652 (flatpak maintainer):
|
|
Have you tested it already? Asking to approve. |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the Linux installer workflow by adding documentation and a default “no-install” behavior, bumps the NDI SDK version to 6.2.0 in packaging scripts, and adds Flatpak library lookup in the plugin loader.
- Add Flatpak NDI library lookup path in the plugin loader
- Bump NDI SDK version from 5.6.0 to 6.2.0 and update package names/maintainers
- Enhance
libndi-get.shwith usage docs, quoting improvements, and default no-install behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plugin-main.cpp | Added Flatpak-specific lookup path for NDI library |
| CI/libndi-package.sh | Updated NDI version, package names, replaces list, and maintainer |
| CI/libndi-get.sh | Added header docs, improved variable quoting, refactored cleanup, and default no-install option |
Comments suppressed due to low confidence (2)
CI/libndi-get.sh:30
- Typo: 'follwoing' should be spelled 'following'.
# The follwoing should work with tmp folder in the user home directory - but not always... So we do not use it.
CI/libndi-get.sh:85
- [nitpick] This and the following cleanup block would be clearer if indented to reflect their nesting inside the
if [ "$1" == "install" ]branch.
echo "Clean-up : Removing temporary folder"
| locations << "/usr/local/lib"; | ||
| locations << "/app/plugins/DistroAV/extra/lib"; | ||
| #endif |
There was a problem hiding this comment.
This Flatpak-specific path is currently added unconditionally; it should be guarded under the Linux code path (e.g., within a #if defined(Q_OS_LINUX) block) to avoid being included on non-Linux builds.
| locations << "/usr/local/lib"; | |
| locations << "/app/plugins/DistroAV/extra/lib"; | |
| #endif | |
| locations << "/usr/local/lib"; | |
| #if defined(Q_OS_LINUX) | |
| locations << "/app/plugins/DistroAV/extra/lib"; | |
| #endif | |
| #endif |
|
Install Script Tested on Ubuntu 24.04. |
Initially to address address #1015 but as @paulpv mentionned a couple time, it is not the best practice to have the script auto-install by default.
Things to discuss & check before commit: