Skip to content

Fix conv_buffer deallocation#1295

Merged
Trouffman merged 2 commits into
masterfrom
codex/fix-memory-deallocation-bug-in-ndi-output.cpp
Jun 12, 2025
Merged

Fix conv_buffer deallocation#1295
Trouffman merged 2 commits into
masterfrom
codex/fix-memory-deallocation-bug-in-ndi-output.cpp

Conversation

@paulpv

@paulpv paulpv commented Jun 11, 2025

Copy link
Copy Markdown
Member

@paulpv

paulpv commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

This is to fix a memory leak freeing up the following array allocation:

o->conv_buffer = new uint8_t[(size_t)height * (size_t)o->conv_linesize * 2]();

o->conv_buffer = new uint8_t[(size_t)height * (size_t)o->conv_linesize * 2]();

@paulpv

paulpv commented Jun 11, 2025

Copy link
Copy Markdown
Member Author

FYI, this bug was found by OpenAI Codex.

@Trouffman
Trouffman self-requested a review June 12, 2025 11:14
@Trouffman
Trouffman merged commit ebddd37 into master Jun 12, 2025
6 checks passed
@Trouffman
Trouffman deleted the codex/fix-memory-deallocation-bug-in-ndi-output.cpp branch June 12, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants