Use previous filter as source for dedicated NDI output filter#1239
Closed
BitRate27 wants to merge 4 commits into
Closed
Use previous filter as source for dedicated NDI output filter#1239BitRate27 wants to merge 4 commits into
BitRate27 wants to merge 4 commits into
Conversation
Trouffman
previously approved these changes
Apr 5, 2025
Collaborator
|
This is pretty crazy the fix was that simple! Reading the doc for this totally makes sense. |
Collaborator
|
@BitRate27 can you check if this would have an impact/solution on this : #969 |
Contributor
Author
|
The user who reported the problem, tried out this fix and sees a black NDI feed output. I can also duplicate this problem. After further investigation, it seems our use of the media-io/video non-public API makes this change not a viable solution. This PR should not be included in the DistroAV as a black screen all the time is worse than not cropping. |
BitRate27
added
the
!DO NOT MERGE!
Trouffman
marked this pull request as draft
April 18, 2025 03:51
Trouffman
added
enhancement
filter-feature
Collaborator
|
@BitRate27 maybe this would be a good start to steer away from the non-public/undocumented media-io/video API. You can get in it in this PR or create a new one and close this one. |
Collaborator
|
THis has been managed in #1343 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a problem reported in #613. The NDI output filter was not using the cropped image output from the Crop/Pad filter before it in the filter list. The fix was as simple as getting the target source (previous filter output) from OBS, instead of the parent source (the actual source).
Verified the size of the NDI output from OBS changes as the size of the crop changes in OBS. Also removed the Crop/Pad filter and verified the full source size was output over NDI.