Skip to content

Performance improvement on NDI Filter#1232

Closed
Marsic1 wants to merge 5 commits into
DistroAV:masterfrom
Marsic1:patch-1
Closed

Performance improvement on NDI Filter#1232
Marsic1 wants to merge 5 commits into
DistroAV:masterfrom
Marsic1:patch-1

Conversation

@Marsic1

@Marsic1 Marsic1 commented Mar 26, 2025

Copy link
Copy Markdown

fixed encoder overload issue reported on #1231

fixed encoder overload issue reported on DistroAV#1231
@BitRate27

Copy link
Copy Markdown
Contributor

This is fantastic work. Thanks for your effort. Could you try to explain how your fixes fix the problem you found. Also, how did you quantify the frame rate decrease? Was it using the FPS number in the bottom right of OBS?

@Trouffman Trouffman changed the title Update ndi-filter.cpp Performance improvement on NDI Filter Mar 27, 2025
@Trouffman

Copy link
Copy Markdown
Collaborator

Thanks for the PR!
Can you provide a summary of the fix put in place?

This is to keep track of the "arguments" for the changes for maintainers.

@Trouffman

Copy link
Copy Markdown
Collaborator

back to draft mode until the bug identified at : #1231 (comment) is addressed.

@Trouffman
Trouffman marked this pull request as draft March 27, 2025 15:12
@Trouffman Trouffman added this to the 6.2.0 milestone Apr 5, 2025
@Trouffman

Copy link
Copy Markdown
Collaborator

@Marsic1 if you have a way to detect/reproduce what you experienced this could be helpful.

I came to change a similar portion of the code while reviewing the open tickets in PR #1266

would love to find out how to measure /reproduce this.

@Trouffman Trouffman added filter-feature For anything that is tied to an NDI Filter. performance labels May 8, 2025
@Trouffman Trouffman modified the milestones: 6.2.0, 6.1.1 May 9, 2025
@Trouffman Trouffman modified the milestones: 6.1.1, 6.1.2 Jun 12, 2025
@Trouffman

Copy link
Copy Markdown
Collaborator

Superseeded by #1343

@Trouffman Trouffman closed this Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filter-feature For anything that is tied to an NDI Filter. performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants