Fix deprecated Qt APIs and a compiler warning for QT 6.8.0#1151
Merged
Conversation
- QDateTime::setTimeSpec -> QDateTime::setTimeZone - QCheckBox::stateChanged -> QCheckBox::checkStateChanged for Qt 6.7 and newer Signed-off-by: Felix Kaechele <[email protected]>
This fixes the following compiler warning:
```
In file included from src/forms/update.cpp:305:
src/obs-support/remote-text.hpp: In constructor ‘RemoteTextThread::RemoteTextThread(std::string, std::vector<std::__cxx11::basic_string<char> >&&, std::string, std::string, int)’:
src/obs-support/remote-text.hpp:51:34: error: ‘RemoteTextThread::headers’ will be initialized after [-Werror=reorder]
51 | std::vector<std::string> headers;
| ^~~~~~~
src/obs-support/remote-text.hpp:42:13: error: ‘int RemoteTextThread::timeoutSec’ [-Werror=reorder]
42 | int timeoutSec = 0;
| ^~~~~~~~~~
src/obs-support/remote-text.hpp:64:16: error: when initialized here [-Werror=reorder]
64 | inline RemoteTextThread(std::string url_,
| ^~~~~~~~~~~~~~~~
```
Signed-off-by: Felix Kaechele <[email protected]>
Collaborator
|
Thanks for the PR. This cannot be fixed until OBS 31 is out as the require QT version is not used yet. This is because you are trying to build with QT6.8, the plugin-template for OBS plugin is based on Qt 6.6.3 (still) and some of the functions used to replace the deprecated one are not reliable Pre Qt 6.7. Will keep his PR here for visibilty but will drop it as Draft. |
Trouffman
marked this pull request as draft
December 3, 2024 23:42
Trouffman
changed the title
12 tasks
Trouffman
self-requested a review
December 30, 2024 00:23
Trouffman
marked this pull request as ready for review
December 30, 2024 00:23
Trouffman
added
Dependencies
Trouffman
changed the title
Trouffman
marked this pull request as draft
February 10, 2025 02:51
Collaborator
|
This will most likely be merged/addressed as soon as we start using the latest OBS-deps. This will impact more than just QT things. See details on : #1251 |
Collaborator
|
This will be addressed as soon as we get #1251 done (might be part of it) |
Trouffman
added a commit
that referenced
this pull request
Jul 9, 2025
Trouffman
marked this pull request as ready for review
August 29, 2025 13:17
Trouffman
approved these changes
Aug 29, 2025
This was referenced Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Got warned about these when building on Fedora 41 with Qt 6.8.0 and gcc version 14.2.1.