Skip to content

Delete obs-ndi plugin on macos after installing DistroAV#1136

Merged
Trouffman merged 6 commits into
DistroAV:developfrom
BitRate27:rmobsndi
Nov 17, 2024
Merged

Delete obs-ndi plugin on macos after installing DistroAV#1136
Trouffman merged 6 commits into
DistroAV:developfrom
BitRate27:rmobsndi

Conversation

@BitRate27

Copy link
Copy Markdown
Contributor

Users were instructed to manually delete the obs-ndi.plugin from obs-studio before installing DistroAV. This proved to be a challenge for some users and is prone to user error. With this PR, the deletion of the old plugin is done automatically as part of the installation of the DistroAV plugin.

Target Usage:

  • MacOS package installer

The PR solves this issue by:

  • Modifying the existing UninstallOBS-NDI.sh script to also delete the plugin for all users
  • Add the script to the MacOS package
  • Execute the script after installation of DistroAV, causing the deletion of the obs-ndi.plugin

Testing:

  • Was only able to test the script deletes the plugin.
  • Since I cannot build on MacOS, delivery and execution of the script when the package is installed was NOT tested.

@Trouffman

Copy link
Copy Markdown
Collaborator

I will be testing this for Mac OS.

@Trouffman

Copy link
Copy Markdown
Collaborator

This will NOT remove files in the system library as this is "offlimit" for scripts.
Files should not be in there anyway.

@Trouffman
Trouffman requested a review from paulpv November 8, 2024 19:16
@Trouffman
Trouffman changed the base branch from master to develop November 8, 2024 20:29
Comment thread build-aux/postinstall
@paulpv

paulpv commented Nov 9, 2024

Copy link
Copy Markdown
Member

This will NOT remove files in the system library as this is "offlimit" for scripts. Files should not be in there anyway.

So why does it even try?

@paulpv

paulpv commented Nov 9, 2024

Copy link
Copy Markdown
Member

Who has a problem with this?
1% of our users?
Can't they just learn how to read?

@Trouffman

Copy link
Copy Markdown
Collaborator

This will NOT remove files in the system library as this is "offlimit" for scripts. Files should not be in there anyway.

So why does it even try?

Couple things there :

  • The script will not be able to access the systems Application Support folder by default. (No access unless ran as admin or root or else

  • But, if users ended up with files there this means the script should also have access. )I could not fully test that..

You review is important, we could only target the OBS-ndi files in the user ~/Library.

Note that there is another PR adding the path of the detected OBS-ndi that should help most requests.

This was the main source for support requests coming in the last weeks as in "I followed the install instructions but it still says it's there".

@paulpv

paulpv commented Nov 10, 2024

Copy link
Copy Markdown
Member

Understood. Just seems like a lot of work for "a few" users.

Still, it is nice to have I guess. I just wouldn't want it to cause more problems than it is trying to fix.

I wouldn't want it to fix a problem for 3 users [that can't/won't read/follow directions] but cause a problem for hundreds.

@paulpv

paulpv commented Nov 10, 2024

Copy link
Copy Markdown
Member

I would still like to move the postinstall script from the generic [all platforms] build-aux to cmake/macos/resources [macos specific]

Comment thread cmake/windows/resources/installer-Windows.iss.in Outdated
@Trouffman

Copy link
Copy Markdown
Collaborator

@BitRate27 I see that the postinstall & script folder is not being deleted after distroav install.

I am not keen on creating garbage files, we should revisit this approach.

@BitRate27

Copy link
Copy Markdown
Contributor Author

Thanks! Will not be able to look at this until Dec 2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants