Fixes #1108: Temporary Fix for Deprecated Qt functions#1109
Fixes #1108: Temporary Fix for Deprecated Qt functions#1109AniketBose369 wants to merge 2 commits into
Conversation
|
@AniketBose369 Please resolve the conflicts. |
| auto utcDateTime = QDateTime::fromString( | ||
| pluginUpdateInfo.releaseDate, Qt::ISODate); | ||
| utcDateTime.setTimeSpec(Qt::UTC); | ||
| //utcDateTime.setTimeSpec(Qt::UTC); fix it in issue-1108 |
| config->AutoCheckForUpdates()); | ||
| connect(ui->checkBoxAutoCheckForUpdates, | ||
| &QCheckBox::stateChanged, this, [](int state) { | ||
| //&QCheckBox::stateChanged, fix it in issue-1108 |
|
Ok
…On Fri, 18 Oct, 2024, 4:50 am Paul Peavyhouse, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/forms/obsndi-update.cpp
<#1109 (comment)>:
> @@ -49,6 +49,8 @@ Inspiration(s):
#include <QTimer>
#include <QUrlQuery>
+#include <QTimeZone>
group with above #includes sorted alphabetically
—
Reply to this email directly, view it on GitHub
<#1109 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A57UWZCDYUADN54BIXYDYHTZ4BA4PAVCNFSM6AAAAABQABJW3GVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGNZWGUZTCMBVHA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
2de8c56 to
2e73953
Compare
|
Done |
|
@AniketBose369 Please fix the conflicts |
| ui->checkBoxAutoCheckForUpdates->setChecked( | ||
| config->AutoCheckForUpdates()); | ||
| connect(ui->checkBoxAutoCheckForUpdates, | ||
| <<<<<<< HEAD:src/forms/obsndi-update.cpp |
There was a problem hiding this comment.
This is not how to resolve a code conflict
|
It seems obs-studio reverted the move of Qt to 6.7 on Sep 12 ( obsproject/obs-deps@a0d8666 ) and went back to 6.6.3. This means the new checkStateChanged signal is not in the Qt from obs-studio rn. |
|
Actually I compiled and run DistroAV(basically linked the libndi.so.6 with
5) with the changes I made and the latest obs ran fine.
…On Tue, Oct 22, 2024, 9:04 PM BitRate27 ***@***.***> wrote:
It seems obs-studio reverted the move of Qt to 6.7 on Sep 12 (
***@***.***
<obsproject/obs-deps@a0d8666>
) and went back to 6.6.3. This means the new checkStateChanged signal is
not in the Qt from obs-studio rn.
—
Reply to this email directly, view it on GitHub
<#1109 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A57UWZATXFNSYAVSC74LOWDZ4ZV7JAVCNFSM6AAAAABQABJW3GVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMRZGYYTENJSHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Not exactly sure why that worked, but until they move to 6.7, we have to hold off as we won't be able to build. Since they reverted back, there must have been a major issue with 6.7, so we should wait until obs-studio settles on a new version. We can even look at this in Qt 6.8 as this one API isn't removed until 6.9. |
|
@AniketBose369 @BitRate27 Shall we close this for now? |
|
Yeah that seems the right choice |
|
PR closed as this is "too early". Revise / re-submit PR when :
To-do :
|
|
@AniketBose369 a fix for you need has been merged to master. see #1151 |
4 participants
No description provided.