Check for ndiLib when destroying receiver and framesync#1084
Merged
Conversation
Collaborator
|
Great! This was something I was experiencing as well recently, even added a comment about it in the code. Looking to see if this can be added in the next release too. |
Trouffman
added
enhancement
Interface (UI/UX)
BitRate27
commented
Sep 3, 2024
BitRate27
left a comment
BitRate27
left a comment
Contributor
Author
There was a problem hiding this comment.
Looks good! Thanks for adding.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The 100ms delay if no_of_connections == 0 can mean the thread loop will exit after the ndiLib has been destroyed in module unload. Adding a check for a valid ndiLib link before calling destroy methods will keep shutdown from crashing.