Skip to content

[Bug]: Updating/Installing DistroAV on Windows causes uninstall of some OBS plugins (possibly other apps?) #1440

Description

@paulpv

Is there an existing issue for this?

  • I have searched the existing issues and did not find a similar issue

This bug exists on the latest available release of DistroAV and supported environment?

  • I have checked this bug still exists on the latest available version of DistroAV.
  • I have checked that my OS / OBS / NDI versions are supported & up-to-date.

OBS Log [URL] - Important!

No response

Issue reported - Current Behavior

As reported per Discord user Jayb1200:
https://discord.com/channels/1082173788101279746/1170853330470322246/1495943591917518908

Updated to DistoAV 6.2 and it uninstalled StreamUP, Downstreamkeyer & SceneAsTransition Plugins? i had to reinstall them and everythings all good now, just a heads up.

The reason was discovered by @BitRate27:
https://discord.com/channels/1082173788101279746/1170853330470322246/1496070779928842240

I think they are not installing with the guid, instead they are installing as {}_is1 which we uninstall because of the same bug in our installer in 6.1.

Image

@BitRate27 opened StreamUPTips/obs-streamup#40.

This affects more than just StreamUP.

DistroAV's uninstall of {}_is1 should also check the DisplayName and only uninstall {}_is1 if DisplayName is DistroAV.
I did not know it is easily possible for other plugins to also install as {}_is1.

Expected Behavior

Installing or Updating DistroAV should not uninstall any other Windows apps/obs-plugins

Steps To Reproduce

  1. Install or Update DistroAV to v6.1.1 or greater

Environment

- OS: Windows
- OBS: n/a
- DistroAV: since 6.1.1 https://github.com/DistroAV/DistroAV/commit/eb4d04b45de6e6949490d4aa4617d9b2f5520387
- NDI: n/a

Pre-Check for Bug Report

  • I am able to reproduce the bug following the steps provided above
  • I have confirmed this bug exist on more than one device/computer
  • I have tested using a new scene collection to reproduce the issue
  • I have tested on a 'clean' OBS installation (aka with no other scripts or plugin installed)
  • I am filing this bug report as a Human and have reviewed its content to the best of my ability to ensure it's accurate.

Metadata

Metadata

Assignees

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions