Skip to content

[Bug]: audio_thread created by ndi-6.1.1 is not closed during exiting #1335

Description

@walker-WSH

Is there an existing issue for this?

  • I have searched the existing issues and did not find a similar issue

This bug exists on the latest available release of DistroAV and supported environment?

  • I have checked this bug still exist on the latest available version of DistroAV
  • I have checked that my OS / OBS / NDI versions are supported

OBS Log [URL] - Important!

No response

Issue reported - Current Behavior

This crash is found at user's side with PRISM exiting. I do not find the reproduce steps.
the audio_thread created by ndi (6.1.1) is not closed during exiting.

1. obs_shutdown has been called

Image

2. However, the audio_output in libobs (0X1FE37C1D540) created by 3rd plugin is not exited

Image

3. we can find this audio_output is set for this output (0X1FE37CF56A0)

Image

4. this output (0X1FE37CF56A0) is created by ndi plugin

Image

Expected Behavior

during exiting, the created audio_output should be closed

Steps To Reproduce

I have not reproduced it.
This crash is happened at the user's with PRISM Live Studio

Environment

- OS:  Windows 11(x64)
- OBS:  PRISM 5.0.0.635
- DistroAV: 6.1.1

This issue was modified in the past
https://github.com/DistroAV/DistroAV/pull/996

I find `audio_output_close` is only called in `preview_output_stop`. 
`preview_output_stop` is called from `OBS_FRONTEND_EVENT_EXIT》preview_output_deinit`

That front event is also sent from PRISM as obs's code.

Pre-Check for Bug Report

  • I am able to reproduce the bug following the steps provided above
  • I have confirmed this bug exist on more than one device/computer
  • I have tested using a new scene collection to reproduce the issue
  • I have tested on a 'clean' OBS installation (aka with no other scripts or plugin installed)

Metadata

Metadata

Assignees

Labels

Output (Program/Preview)relate to NDI Output Progam or Previewbugcrashif this issue / bug cause a crash

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions