Skip to content

[Tweak]: Only read the installGUID and never write it to avoid possible conflict in App config file #1171

Description

@Trouffman

Pre-Report Checks

  • This is not a Bug Report
  • This is not a Feature Request
  • This is not a Support Request
  • This could not be reported anywhere else (Issue/discussion)

Description of your report

Looking at the codebase the plugin use for the update. One of the required element is the "installGUID", this is the same used by the OBS Project.

This is actively set by OBS this means :

  • Realistically, it would never be set by the plugin. -> Making that part of the codebase "redundant"
  • If, for any reason, the plugin does write it, it is writing this in the General part of the config file AND could conflict (none report so far) with the way OBS Core is already doing.

The proposed changes :

  • The plugin should only "Read the InstallGUID from the config file"
  • If the installGUID is not set, assume the user does not want to have updates.

Expected avantages

  • Simplify codebase
  • Avoid maintaining non-used code
  • Reduce possible conflicts with OBS Core
  • Simplify Update mechanism

Test done already

  • Confirmed by testing that the installGUID is always created (by OBS), even when the OBS updates are turned off in UI & via config file. BUT this is available in the config only when there is a "save" event (closing OBS or going into the settings)

Possible impact : if a user is launching OBS for the first time with DistroAV, we might get an empty (or placeholder) GUID. This should be pretty limited.

I could not report this anywhere else because...

It is a future-looking improvement, not a bug per say.

Work in Progress

https://github.com/DistroAV/DistroAV/tree/plugin-update-tweak-1171

contributions are welcome

Metadata

Metadata

Assignees

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions