Conversation
There was a problem hiding this comment.
Pull request overview
This PR refactors the score handling mechanism by grouping the score value and its type (CP, MATE, or ERR) into a single Score struct. This improves the API design by reducing parameter count and ensuring that score values and their types are always handled together as a cohesive unit.
Key changes:
- Introduced
engine::Scorestruct containingtypeandvaluefields - Removed
UciEngine::lastScoreType()method and updatedUciEngine::lastScore()to return aScorestruct - Updated
DrawTracker::update()andResignTracker::update()to accept a singleScoreparameter instead of separate score and type parameters
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app/src/engine/uci_engine.hpp | Defines new Score struct and updates lastScore() method signature to return Score instead of int64_t |
| app/src/engine/uci_engine.cpp | Implements updated lastScore() method that returns Score struct and removes deprecated lastScoreType() method |
| app/src/matchmaking/match/match.hpp | Updates DrawTracker and ResignTracker classes to accept const engine::Score& parameter |
| app/src/matchmaking/match/match.cpp | Updates all call sites to use the new Score struct API |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.