fix: dont attach illegal moves to pgn#943
Merged
Conversation
Contributor
|
Hm, I get this: So may need special treatment for first move being illegal. See also cutechess/cutechess#572. |
Owner
Author
|
so the body is just supposed to be |
Contributor
|
I would leave the eval and time details out. Like you did for the case when it's not the first move. Apart from that, yes. |
Owner
Author
|
okay now should look like this if the first move was also illegal |
Contributor
|
lgtm |
Owner
Author
|
okay nice i haven't tested with your test engines but instead just used the unit test to create the expected version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #942