refactor: replace raw new[] with std::make_unique in getCpuInfo#920
Merged
Disservin merged 1 commit intoDisservin:masterfrom Sep 22, 2025
Merged
Conversation
Owner
|
We are still using unique pointers but yea this is more idiomatic c++ so fine with me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
According to Scott Meyers Effective Modern C++
Item 21: Prefer std::make_unique and std::make_shared to direct use of new.
This is my first contribution, I have made sure the unit tests have passed.