Skip to content

CSS Grid: named lines and areas#840

Merged
nicoburns merged 71 commits intomainfrom
named-grid-lines-and-areas
Aug 1, 2025
Merged

CSS Grid: named lines and areas#840
nicoburns merged 71 commits intomainfrom
named-grid-lines-and-areas

Conversation

@nicoburns
Copy link
Copy Markdown
Collaborator

@nicoburns nicoburns commented May 24, 2025 •
edited
Loading

Objective

Support named grid lines and named grid areas in CSS grid.

Changes made

  • Make Style generic over an abstract string type (so clients can use the formats their strings are already in (e.g. Atom for Servo/Blitz))
  • Add a CustomIdent type (same string trait)
  • Add grid_template_row_names and grid_template_column_names properties (Vec of lines names)
  • Add GridTemplateArea struct and grid_template_areas property
  • Add a new GridTemplateComponent type so that repetitions can specify line names
  • Add NamedLine and NamedSpan variants to GridPlacement (and make public GridPlacement no longer generic)
  • Add a whole bunch more associated types to the GridContainerStyle trait to allow zero-cost iteration over complex nested grid definitions.

Context

This is necessary to correctly layout websites such docs.rs, wikipedia.org and news.bbc.co.uk

@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch 3 times, most recently from a98db79 to 9a0aeba Compare May 24, 2025 23:58
@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch 4 times, most recently from e4f56fb to ba97f8f Compare July 29, 2025 19:22
@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch 5 times, most recently from c4325db to 9b10d09 Compare July 30, 2025 16:46
@nicoburns nicoburns changed the title WIP: Named grid lines and areas CSS Grid: named lines and areas Aug 1, 2025
nicoburns added 17 commits August 1, 2025 18:26
@nicoburns
Named grid lines and areas WIP
76643bb 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Make Style generic over CustomIdent type
1e10e4b 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Use Iterator for grid areas style
7a7ed19
@nicoburns
Fixup examples
15b3094
@nicoburns
Impl Default for generic Style<S>
01bd86b 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix is_definite resolution in placement
29ad535 
We cannot assume that a named line placement is valid
@nicoburns
Implement named lines
a6cabfa 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Add named grid line support
55cad75 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Correctly floor max-track-sizing-function by min-tracking-sizing-func…
6604f31 
…tion when computing auto-repeated tracks

Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Resolve track-size percentages against explicit min-size style if
28e908a 
parent size is indefinite.
@nicoburns
Account for known_dimensions when determining auto-repeat fit strategy
a4bc771 
If known_dimensions is set in the axis, then the container counts as
having a definite width and should not fallback to the min-width fitting
strategy.
@nicoburns
WIP
41a272a 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
WIP: refactor all the traits
acbe76d 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
WIP: pass style to explicit grid helpers
cfbd987 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Implement repeated named grid lines
e1443d4 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Implement non-existent line name quirk
2314112
@nicoburns
Fix transposed rows and columns
1c1a577
nicoburns added 15 commits August 1, 2025 18:26
@nicoburns
Disabled unused_imports, unused_variables and unused_mut when default
d83007e 
features are not enabled.
@nicoburns
Add dummy PhantomData field to Style
ba81bc7
@nicoburns
Fix build with no default features
3ad91f5 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix benchmarks
4bfafca
@nicoburns
Bump MSRV to 1.80
1793b94
@nicoburns
Document GenericGridTemplateComponent and GenericRepetition
16573ae 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Fix remaining clippy lints
ed9a2e2
@nicoburns
Remove commented code
eda708f
@nicoburns
Use String as the default string type and reduce MSRV back down to 1.65
d50307e 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns
Typo column -> row
abbde71
@nicoburns
Set explicit track counts in name resolver before placement
8123d36
@nicoburns
Fix current_line counting when iterating over track names
6fa9248
@nicoburns
Fix computation of fallback tracks for non-existent named tracks
1aa267a
@nicoburns
Allow line number of 0 when computing fallback line for non-existent …
5a3edb6 
…named line
@nicoburns
Fix benchmark build
d6c5707 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch from 0114b52 to d6c5707 Compare August 1, 2025 17:26
@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch 3 times, most recently from f6c9527 to 5f1e7b0 Compare August 1, 2025 22:06
@nicoburns nicoburns added the enhancement New feature or request label Aug 1, 2025
@nicoburns nicoburns marked this pull request as ready for review August 1, 2025 22:17
@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch from 5f1e7b0 to 8352beb Compare August 1, 2025 22:18
@nicoburns
Implement named spans
1822b95 
Signed-off-by: Nico Burns <[email protected]>
@nicoburns nicoburns force-pushed the named-grid-lines-and-areas branch from 8352beb to 1822b95 Compare August 1, 2025 22:18
@nicoburns nicoburns merged commit c3e8000 into main Aug 1, 2025
34 checks passed
@nicoburns nicoburns deleted the named-grid-lines-and-areas branch August 1, 2025 22:24
@nicoburns nicoburns mentioned this pull request Aug 1, 2025
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

CSS Grid: Support named grid lines and grid areas

1 participant

@nicoburns