change layout back to be relative#6
Merged
ealmloff merged 3 commits intoDioxusLabs:masterfrom May 10, 2022
mockersf:remove_round_layout_changes
Merged
change layout back to be relative#6ealmloff merged 3 commits intoDioxusLabs:masterfrom mockersf:remove_round_layout_changes
ealmloff merged 3 commits intoDioxusLabs:masterfrom
mockersf:remove_round_layout_changes
Conversation
mockersf
changed the title
ealmloff
approved these changes
May 10, 2022
Member
There was a problem hiding this comment.
Looks good. It would be nice to get the generated tests working again. The position being relative fixes the re-layout movement issue #2 fixed, and it is trivial for any downstream crate to get the absolute position, if they want it.
Thank You!
Contributor
Author
|
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
change layout back to be relative
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert #2 and vislyhq/stretch#87
The test from #2 is still present and still successful.
With those two PRs, the value returned for location is the absolute value. Without, the value is relative to its parent.
The test expect the value to be relative, as for example in this test:
https://github.com/DioxusLabs/stretch/blob/02033c0e8f52c9d12c40557804162eadd3f8a3a2/tests/generated/flex_basis_slightly_smaller_then_content_with_flex_grow_large_size.rs#L77-L84
where
node10has a location.x of 0 even though its parentnode1has a location.x of 80This PR makes it work OK for Bevy again