Make padding/border size floor node size#372
Merged
alice-i-cecile merged 22 commits intoDioxusLabs:mainfrom Mar 9, 2023
Merged
Make padding/border size floor node size#372alice-i-cecile merged 22 commits intoDioxusLabs:mainfrom
alice-i-cecile merged 22 commits intoDioxusLabs:mainfrom
Conversation
nicoburns
force-pushed
the
fix/border-floors-node-size
branch
2 times, most recently
from
e5866a1 to
cec3c2e
Compare
nicoburns
changed the title
Collaborator
Author
|
Some notes:
The tests in |
nicoburns
force-pushed
the
fix/border-floors-node-size
branch
2 times, most recently
from
96df489 to
1509bdc
Compare
nicoburns
force-pushed
the
fix/border-floors-node-size
branch
from
d32afdd to
71adf0c
Compare
nicoburns
changed the title
Collaborator
Author
|
I believe this is now ready if we ignore aspect-ratio. Which I'm inclined to do for the time being because I think that's quite a deep rabbit hole to go down and very unlikely combination of styles for people to be using. |
nicoburns
force-pushed
the
fix/border-floors-node-size
branch
2 times, most recently
from
6bcc01b to
46a354c
Compare
alice-i-cecile
requested changes
Mar 9, 2023
Collaborator
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
A couple of small quality issues, then this LGTM. We should resolve clippy failures from the new Rust version in their own PR.
nicoburns
force-pushed
the
fix/border-floors-node-size
branch
from
46a354c to
82aff45
Compare
…g flex container main size
nicoburns
force-pushed
the
fix/border-floors-node-size
branch
from
82aff45 to
aa251a1
Compare
alice-i-cecile
approved these changes
Mar 9, 2023
Weibye
reviewed
Mar 11, 2023
Collaborator
Weibye
left a comment
Weibye
left a comment
There was a problem hiding this comment.
Your comments are incredibly insightful and helpful, so keep that up :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix node sizing behaviour where size is/should be determined by border.
(PR currently only contains failing tests)
Context
bevyengine/bevy#7795 (comment)