Rename PositionType and Position in accordance to specs#295
Merged
nicoburns merged 6 commits intoDioxusLabs:mainfrom Dec 27, 2022
Merged
Rename PositionType and Position in accordance to specs#295nicoburns merged 6 commits intoDioxusLabs:mainfrom
nicoburns merged 6 commits intoDioxusLabs:mainfrom
Conversation
Weibye
requested review from
alice-i-cecile and
nicoburns
and removed request for
alice-i-cecile
alice-i-cecile
added
usability
Collaborator
|
This looks good to me, but CSS Grid tests are failing because those files haven't been updated. You need to run tests with @alice-i-cecile This is becoming an increasingly annoying problem for me when working on Taffy. How would you feel about making the grid feature on by default? (and perhaps renaming it to just |
Collaborator
|
I'm fine to enable them by default now! |
alice-i-cecile
approved these changes
Dec 27, 2022
Collaborator
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Happy to merge this once CI is passing.
Weibye
force-pushed
the
position-rename
branch
from
1285f93 to
367892e
Compare
Collaborator
Author
|
All should be fixed now :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fix #271