Cleanup new_with_children() uses#194
Merged
alice-i-cecile merged 3 commits intoDioxusLabs:mainfrom Jun 26, 2022
Merged
Conversation
alice-i-cecile
approved these changes
Jun 26, 2022
Collaborator
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Dramatically nicer!
And yeah, we can leave the generation script for now.
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Cleanup `new_with_children()` uses * Format * Update scripts/gentest/src/main.rs Co-authored-by: Alice Cecile <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #189
Context & Feedback
I haven't made any changes to the generated code nor it's generation-script, so it will keep producing leaf-nodes using
new_with_children()but I reckon that is acceptable.