Add guideline to write tests#185
Merged
alice-i-cecile merged 7 commits intoDioxusLabs:mainfrom Jun 20, 2022
Merged
Conversation
alice-i-cecile
added
meta
TimJentzsch
reviewed
Jun 20, 2022
Collaborator
TimJentzsch
left a comment
TimJentzsch
left a comment
There was a problem hiding this comment.
I did a first pass on formatting
alice-i-cecile
requested changes
Jun 20, 2022
Collaborator
alice-i-cecile
left a comment
alice-i-cecile
left a comment
There was a problem hiding this comment.
Some simple clarity changes for you :) This is almost ready; we can revise this as we go.
Co-authored-by: Alice Cecile <[email protected]>
Collaborator
Author
Yup, those are clearer, thanks! |
alice-i-cecile
approved these changes
Jun 20, 2022
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Add test guideline * Space around lists * Fix idents and numbering * Remove double wrapped integration-test example * Add note of paramter-based testing * Apply suggestions from code review Co-authored-by: Alice Cecile <[email protected]> Co-authored-by: Alice Cecile <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
As discussed in #179, this adds a short guideline for how to write and organise tests within
taffyContext
Mostly to help people such as myself that are unfamiliar with this, but also just to ensure consistency and consensus through the project.
Also, we need a lot of tests to any way we can make it simpler to contribute on the testing side is a win!
Feedback wanted
I don't want it to be too terse or verbose, so please comment on phrasing ++