Merged
Conversation
Collaborator
|
Thanks! This is a great place to start. If you're interested in adding spell-checking to the CI; please feel free to open a PR :) On some projects it's too noisy due to invented words, but I think it should be fine here as long as we can add an allowlist. |
alice-i-cecile
approved these changes
Jun 14, 2022
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
Co-authored-by: Marcello Vaz <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
I'm trying to start contributing to this project and fixing comment typos seemed like a good way to do so :)
Context
Discuss any context that may be needed for reviewers to understand the changes you've made.
This may include related issues, previous discussion, or links to documentation or code.
Feedback wanted
I'm not sure if this is common, but maybe it would be cool to have some spell checking in the CI pipeline. Specially since all of the typos were caught by a VSCode extension, so it should be easy to automate.
VSCode also removed some whitespaces when saving. I don't think this will cause any issues, but let me know!