Make MeasureFunc Send and Sync#157
Merged
alice-i-cecile merged 3 commits intoDioxusLabs:mainfrom Jun 12, 2022
Merged
Conversation
alice-i-cecile
added
usability
alice-i-cecile
changed the title
MeasureFunc Send and Sync
SkiFire13
reviewed
Jun 12, 2022
Comment on lines
+336
to
+338
| fn measure_func_is_send_and_sync() { | ||
| fn is_send_and_sync<T: Sync>() {} | ||
| is_send_and_sync::<MeasureFunc>(); |
There was a problem hiding this comment.
This test is missing the T: Send bound.
Collaborator
Author
There was a problem hiding this comment.
Good eye. I'll fix this ASAP.
jkelleyrtp
pushed a commit
that referenced
this pull request
Oct 10, 2022
* Make MeasureFunc Send and Sync * Update RELEASE notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Fixes #146. This was much more straightforward than I was concerned it might be, we just needed to add a trait bound. This will unblock #27.