Skip to content

Improve error message when chromedriver is not installed#147

Merged
alice-i-cecile merged 2 commits intoDioxusLabs:mainfrom
Weibye:chromedriver-error-improvement
Jun 11, 2022
Merged

Improve error message when chromedriver is not installed#147
alice-i-cecile merged 2 commits intoDioxusLabs:mainfrom
Weibye:chromedriver-error-improvement

Conversation

@Weibye
Copy link
Copy Markdown
Collaborator

@Weibye Weibye commented Jun 11, 2022

Objective

Fixes #45

This fixes the error message, but I'm not able to get the gentest to run correctly from only installing this. Do we have other dependencies that needs to be installed?

@mockersf Was there other things you did to get it to produce an output?

@Weibye Weibye marked this pull request as draft June 11, 2022 08:39
@Weibye Weibye marked this pull request as ready for review June 11, 2022 08:42
@mockersf
Copy link
Copy Markdown
Contributor

mockersf commented Jun 11, 2022

nop, just installed chromedriver and chrome

what error message did you get?

@Weibye
Copy link
Copy Markdown
Collaborator Author

Weibye commented Jun 11, 2022

nop, just installed chromedriver and chrome

what error message did you get?

Ah, hang on. My mistake. It was running correctly except turns out that no files are changed when you don't make any changes to the files 🙃

It works as expected now, thanks!

@alice-i-cecile alice-i-cecile added the usability Make the library more comfortable to use label Jun 11, 2022
@alice-i-cecile alice-i-cecile enabled auto-merge (squash) June 11, 2022 14:34
@Weibye Weibye changed the title Improve error message when missing chromedriver Improve error message when chromedriver is not installed Jun 11, 2022
@alice-i-cecile alice-i-cecile merged commit f324ad8 into DioxusLabs:main Jun 11, 2022
@Weibye Weibye deleted the chromedriver-error-improvement branch June 11, 2022 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

usability Make the library more comfortable to use

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Improve cargo run --package gentest error message when chromedriver is not installed

4 participants