-
Notifications
You must be signed in to change notification settings - Fork 181
Name of position and position_type properties doesn't match CSS spec #271
Copy link
Copy link
Closed
Labels
breaking-changeA change that breaks our public interfaceA change that breaks our public interfacedocumentationImprovements or additions to documentationImprovements or additions to documentationgood first issueGood for newcomersGood for newcomersusabilityMake the library more comfortable to useMake the library more comfortable to use
Description
Problem
- What we call
position_typeis Taffy ispositionin the CSS spec https://developer.mozilla.org/en-US/docs/Web/CSS/position - What we call
positionisinsetin the CSS spec. https://developer.mozilla.org/en-US/docs/Web/CSS/inset
Context
I suspect inset hadn't yet been specified when Taffy/Stretch was first created.
Proposal
Rename position to inset and position_type to position to align with the CSS names for these properties.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
breaking-changeA change that breaks our public interfaceA change that breaks our public interfacedocumentationImprovements or additions to documentationImprovements or additions to documentationgood first issueGood for newcomersGood for newcomersusabilityMake the library more comfortable to useMake the library more comfortable to use