Repository navigation
Commit 9b7b1ba
authored
core: keep recordings when the Permission Model blocks fsync (anomalyco#1907)
Since Node 26.9.0, `FileHandle.sync()` throws `ERR_ACCESS_DENIED`
whenever the Permission Model is on (nodejs/node#65431). `AudioRecorder`
finalizes a recording with `sync()` and `close()`, so under
`--permission` every recording failed with "Audio recorder finalize
failed" and was discarded. OpenTUI's own Node test lane runs with
`--permission` and hits this as soon as CI moves past Node 26.7.
The recorder now closes the file without the sync when that call is
denied, then publishes it as usual. Any other sync error still fails the
recording and keeps the destination. The audio capture docs say that
under `--permission` the file is not forced to disk before the rename.
Tested by rows in the existing sync-failure table (denied: the recording
completes and the file is closed; another error code: it still fails)
and by the core Node lane on Node 26.7.0 and 26.13.0.1 parent b9028c3 commit 9b7b1ba
3 files changed
Lines changed: 21 additions & 10 deletions
File tree
- packages
- core/src
- tests
- web/src/content/docs/application-apis
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2519 | 2519 | | |
2520 | 2520 | | |
2521 | 2521 | | |
2522 | | - | |
| 2522 | + | |
| 2523 | + | |
| 2524 | + | |
| 2525 | + | |
2523 | 2526 | | |
2524 | 2527 | | |
2525 | 2528 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2104 | 2104 | | |
2105 | 2105 | | |
2106 | 2106 | | |
2107 | | - | |
| 2107 | + | |
2108 | 2108 | | |
2109 | 2109 | | |
2110 | 2110 | | |
| |||
2113 | 2113 | | |
2114 | 2114 | | |
2115 | 2115 | | |
2116 | | - | |
2117 | 2116 | | |
2118 | 2117 | | |
2119 | 2118 | | |
| 2119 | + | |
2120 | 2120 | | |
2121 | 2121 | | |
2122 | | - | |
| 2122 | + | |
| 2123 | + | |
2123 | 2124 | | |
2124 | 2125 | | |
2125 | 2126 | | |
2126 | | - | |
2127 | | - | |
| 2127 | + | |
| 2128 | + | |
| 2129 | + | |
| 2130 | + | |
2128 | 2131 | | |
2129 | 2132 | | |
2130 | 2133 | | |
| |||
2134 | 2137 | | |
2135 | 2138 | | |
2136 | 2139 | | |
2137 | | - | |
2138 | | - | |
2139 | | - | |
| 2140 | + | |
| 2141 | + | |
| 2142 | + | |
| 2143 | + | |
| 2144 | + | |
| 2145 | + | |
2140 | 2146 | | |
| 2147 | + | |
2141 | 2148 | | |
2142 | 2149 | | |
2143 | | - | |
2144 | 2150 | | |
2145 | 2151 | | |
2146 | 2152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
287 | 287 | | |
288 | 288 | | |
289 | 289 | | |
| 290 | + | |
| 291 | + | |
290 | 292 | | |
291 | 293 | | |
292 | 294 | | |
| |||
0 commit comments