LIMS-1917: Track status of strategy pipelines#993
Merged
ndg63276 merged 2 commits intopre-release/2025-R5.1from Oct 28, 2025
Merged
Conversation
gfrn
reviewed
Oct 28, 2025
| _.each(res['screening'], function(sc, n) { | ||
| this.ui.strat.append(n+': '+val[sc]+' ') | ||
| var strats = {} | ||
| _.each(sc, function(a) { |
Collaborator
There was a problem hiding this comment.
We could maybe use native JS here, but it doesn't bother me too much
gfrn
approved these changes
Oct 28, 2025
ndg63276
added a commit
that referenced
this pull request
Nov 11, 2025
* LIMS-1759: Add pages to create and view ligands (#957) * LIMS-1759: Add pages to add/view/list ligands, add PDBS, and add to samples * LIMS-1759: Add ligands to samples in plates * LIMS-1759: Fix bug where ligands were added multiple times * LIMS-1759: Fix error with too few args --------- Co-authored-by: Mark Williams <[email protected]> * LIMS-1926: Hide barcode field when viewing a puck (#991) Co-authored-by: Mark Williams <[email protected]> * LIMS-1963: Load all logins for a proposal (#998) Co-authored-by: Mark Williams <[email protected]> * LIMS-1917: Track status of strategy pipelines (#993) * LIMS-1917: Track status of strategy pipelines * LIMS-1917: Hide strategy pipelines from downstream results --------- Co-authored-by: Mark Williams <[email protected]> --------- Co-authored-by: Mark Williams <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1917
Summary:
There is no mechanism for SynchWeb to be able to display the status of MX strategy/screening jobs. SynchWeb currently looks for records in the Screening table and if a record exists it will show the results of the pipeline and show that the job has completed. If a pipeline doesn't complete (even for a legitimate reason), there will be no record in SynchWeb that the pipeline has run. It would be good if SynchWeb could show the status of the pipeline (running, completed or failed) in the same way that it does for the autoprocessing and downstream pipelines.
The autoprocessing and downstream pipelines store their processing status in the AutoProcProgram table. The Screening table of ISPyB already contains autoProcProgramId as a foreign key which would allow a Screening record to be easily linked to an AutoProcProgram record.
The changes needed to the analysis pipelines will be deployed in January when @pblowey is back from parental leave, but the Synchweb changes can be done ready.
Changes:
ScreeningStrategyWedge.commentsfor the alignment axes, rather thanScreening.comments(both are currently populated, but the latter will not be in future)autoProcProgramIdas well as those without one. Merge the 2 arrays.To test:
$strat_alignconfig variable, so it becomes