LIMS-1923: Fix downstream accordion if files missing from disk#987
Merged
ndg63276 merged 1 commit intopre-release/2025-R4.4from Oct 14, 2025
Conversation
gfrn
approved these changes
Oct 8, 2025
Collaborator
|
It "locks up" for a second or two, but that's because I assume it's waiting on the filesystem, and it happens in prod too, so I guess it's fine |
ndg63276
deleted the
fix/LIMS-1923/downstream-broken-if-ligandfit-file-missing
branch
ndg63276
added a commit
that referenced
this pull request
Oct 22, 2025
* LIMS-1924: Fix update of container owner (#988) * LIMS-1923: Fix downstream accordion if files missing from disk (#987) * LIMS-1876: Fix URL parameters on fault report list (#979) * LIMS-1841: Link downstream jobs to their upstream counterpart (#985) * LIMS-1836: Improvements to reprocessing (#978)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
JIRA ticket: LIMS-1923
Summary:
If the results files for the LigandFit or Shelxt pipelines are no longer on disk, the Downstream Processing accordion will no longer open. We should check the file exists before trying to read it.
Changes:
To test: