Skip to content

LIMS-1841: Link downstream jobs to their upstream counterpart#985

Merged
ndg63276 merged 1 commit intopre-release/2025-R4.4from
improvement/LIMS-1841/link-to-upstream-processing-job
Oct 14, 2025
Merged

LIMS-1841: Link downstream jobs to their upstream counterpart#985
ndg63276 merged 1 commit intopre-release/2025-R4.4from
improvement/LIMS-1841/link-to-upstream-processing-job

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1841

Summary:

Each downstream processing job should have a link to it's upstream counterpart job.

Changes:

  • Add identification of upstream pipeline to FastEP
  • Remove redundant downstream error template file, buttons can be added by setting links to true
  • Remove redundant overriding of the loadAP function for 'sm' data collections
  • Add a 'View Upstream' button for data collection types that require it
  • Make the button open the Auto Processing bar (if needed), then select the correct pipeline, using a callback (if needed)
  • Scroll the window to the Auto Processing pipeline

To test:

  • Open an mx data collection with various auto processing and downstream processing jobs (eg /dc/visit/cm40607-4/id/19735138)
  • Without opening the Auto Processing bar, open the Downstream Processing bar. Click on one of the 'View Upstream' buttons, check the Auto Processing bar opens and the correct pipeline tab is selected.
  • Check the View Upstream button works if the Auto Processing bar is already open, or has been opened and is now closed
  • Check the button works for downstream processing failures
  • Check the button works for FastEP jobs specifically
  • Open an sm data collection (eg /dc/visit/cm40638-4/dcg/16241965) and repeat the checks
  • Open a saxs data collection (eg /dc/visit/cm40642-3/id/19578730) and check there is no View Upstream button
  • Open an xpdf data collection (eg /dc/visit/cm40633-4/id/19719976) and check there is no View Upstream button

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.4 October 14, 2025 09:08
@ndg63276 ndg63276 merged commit 0d89961 into pre-release/2025-R4.4 Oct 14, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1841/link-to-upstream-processing-job branch October 14, 2025 09:10
ndg63276 added a commit that referenced this pull request Oct 22, 2025
* LIMS-1924: Fix update of container owner (#988)

* LIMS-1923: Fix downstream accordion if files missing from disk (#987)

* LIMS-1876: Fix URL parameters on fault report list (#979)

* LIMS-1841: Link downstream jobs to their upstream counterpart (#985)

* LIMS-1836: Improvements to reprocessing (#978)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants