Skip to content

LIMS-1902: Fix plate inspection view for MRC 2 Drop plates#983

Merged
ndg63276 merged 2 commits intopre-release/2025-R4.3from
fix/LIMS-1902/fix-plate-inspection-view-for-mrc-2-drop
Sep 30, 2025
Merged

LIMS-1902: Fix plate inspection view for MRC 2 Drop plates#983
ndg63276 merged 2 commits intopre-release/2025-R4.3from
fix/LIMS-1902/fix-plate-inspection-view-for-mrc-2-drop

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1902

Summary:

The MRC 2 Drop plate type is the only one with a drop_offset_x value, and it has not been used much. #973 fixed the display on creating such a plate and on first viewing it, but there is another view once the plate has inspections to view. This is to fix that view.

Changes:

  • Use a new property to store the drop offset in pixels, so the offset isn't repeatedly converted
  • Use the new offset pixels property to display the drop, the drop number, and to calculate the position for clicking/hovering
  • Make the container type check be case-insensitive

To test:

  • View a plate with inspections eg (/containers/cid/349468)
  • Edit the plate in the database so the containerType is MRC 2 Drop
update Container set containerType='MRC 2 Drop' where containerId=349468;
  • Check the wells and well numbers appear within the drawing of the plate
  • Check you can hover over the wells and they are highlighted
  • Check if you click on a well the inspection image is updated
  • Change the capitalisation of the containerType and repeat the checks
update Container set containerType='mrc 2 drop' where containerId=349468;

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.3 September 30, 2025 11:23
@ndg63276 ndg63276 merged commit dcebe91 into pre-release/2025-R4.3 Sep 30, 2025
2 checks passed
@ndg63276 ndg63276 deleted the fix/LIMS-1902/fix-plate-inspection-view-for-mrc-2-drop branch September 30, 2025 11:26
ndg63276 added a commit that referenced this pull request Oct 14, 2025
* LIMS-1902: Fix plate inspection view for MRC 2 Drop plates (#983)

* LIMS-1902: Fix plate inspection view for MRC 2 Drop plates

* LIMS-1902: Remove whitespace change

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-124: Display Anode results (#981)

* LIMS-124: Display Anode results

* LIMS-124: Round numbers

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1785: Create 'Assign Sample' page for VMXm (#974)

* LIMS-1785: Create 'Assign Sample' page for VMXm

* LIMS-1785: Label link to Assign page correctly

* LIMS-1785: Use consts rather than vars

* LIMS-1785: Fix unassign dialog

---------

Co-authored-by: Mark Williams <[email protected]>

* LIMS-1785: Make sample assign page look for containers on the beamline, not dewars

---------

Co-authored-by: Mark Williams <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants