Skip to content

LIMS-1844: Update archiving messages for 'il' proposals#977

Merged
ndg63276 merged 2 commits intopre-release/2025-R4.2from
improvement/LIMS-1844/update-archiving-messages
Sep 16, 2025
Merged

LIMS-1844: Update archiving messages for 'il' proposals#977
ndg63276 merged 2 commits intopre-release/2025-R4.2from
improvement/LIMS-1844/update-archiving-messages

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1844

Summary:

Description of which proposal codes are deleted (rather than archived) should be set in config rather than hardcoded.

Changes:

  • Add new config var for proposal codes that have data deleted rather than archived
  • Use the proposal code to display this on the visit list, at the top of the visit, and on each data collection

To test:

  • Add this to your config:
$prop_codes_data_deleted = array('in', 'il');
  • Go to an mx proposal, eg mx23694, go to the visit list. Check some visits have a small archive icon next to them, and the tooltip says these visits have been archived
  • Go into one of the archived visits, check the message at the top says the visit has been archived.
  • Check each data collection has an archive icon and a tooltip saying it has been archived.
  • Go to an 'in' proposal, eg in20015. Repeat the same checks, but the messages should say deleted rather than archived.

@gfrn gfrn added Ready to Release Configuration Change Pull requests which necessitate changes to SynchWeb configuration labels Sep 2, 2025
@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.2 September 16, 2025 09:58
@ndg63276 ndg63276 merged commit 1f9bbf2 into pre-release/2025-R4.2 Sep 16, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1844/update-archiving-messages branch September 16, 2025 09:59
ndg63276 added a commit that referenced this pull request Sep 30, 2025
* LIMS-1844: Update archiving messages for 'il' proposals (#977)

* LIMS-1807: Leave 'Mark Dispensing' button active until cancelled (#967)

* LIMS-1799: Checks for safety level should be case insensitive (#955)

* LIMS-1786: Add Dewars column to Shipments page (#958)

* LIMS-1426: Allow setting of pipeline when ranking samples (#950)

* LIMS-1783: Add parent container dropdown for gridboxes (#965)

* LIMS-1903: Fix display of shipping labels (#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Configuration Change Pull requests which necessitate changes to SynchWeb configuration Ready to Release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants