LIMS-1785: Create 'Assign Sample' page for VMXm#974
Merged
ndg63276 merged 5 commits intopre-release/2025-R4.3from Sep 30, 2025
Merged
Conversation
gfrn
reviewed
Aug 14, 2025
| var bl = this.getOption('bl') | ||
| var large = bl in app.config.pucks && app.config.pucks[bl] > 10 | ||
| const bl_capacity = app.options.get('bl_capacity') || {} | ||
| var large = bl in bl_capacity && bl_capacity[bl]['pucks'] > 10 |
Collaborator
There was a problem hiding this comment.
Suggested change
| var large = bl in bl_capacity && bl_capacity[bl]['pucks'] > 10 | |
| const large = bl in bl_capacity && bl_capacity[bl]['pucks'] > 10 |
Since we're making bl_capacity a const (can't suggest on deleted lines, so I can't make bl a const)
Collaborator
gfrn
approved these changes
Aug 27, 2025
…n-sample-page-for-vmxm
ndg63276
added a commit
that referenced
this pull request
Oct 14, 2025
* LIMS-1902: Fix plate inspection view for MRC 2 Drop plates (#983) * LIMS-1902: Fix plate inspection view for MRC 2 Drop plates * LIMS-1902: Remove whitespace change --------- Co-authored-by: Mark Williams <[email protected]> * LIMS-124: Display Anode results (#981) * LIMS-124: Display Anode results * LIMS-124: Round numbers --------- Co-authored-by: Mark Williams <[email protected]> * LIMS-1785: Create 'Assign Sample' page for VMXm (#974) * LIMS-1785: Create 'Assign Sample' page for VMXm * LIMS-1785: Label link to Assign page correctly * LIMS-1785: Use consts rather than vars * LIMS-1785: Fix unassign dialog --------- Co-authored-by: Mark Williams <[email protected]> * LIMS-1785: Make sample assign page look for containers on the beamline, not dewars --------- Co-authored-by: Mark Williams <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


JIRA ticket: LIMS-1785
Summary:
Some beamlines (eg VMXm) don't assign containers to their sample changer, but individual samples. This is to modify the Assign Containers page for such beamlines.
Changes:
To test: