Skip to content

LIMS-1804: Make barcode be required for new plates#969

Merged
ndg63276 merged 1 commit intopre-release/2025-R4.1from
improvement/LIMS-1804/make-barcode-required-for-plates
Sep 2, 2025
Merged

LIMS-1804: Make barcode be required for new plates#969
ndg63276 merged 1 commit intopre-release/2025-R4.1from
improvement/LIMS-1804/make-barcode-required-for-plates

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1804

Summary:

Barcode should be a required field for plates

Changes:

  • Add a validation of required to the barcode field
  • Combine the error message with the message about uniqueness
  • If a user does try and add a barcode that is already used, catch the database error and return a sensible message

To test:

  • Go to any shipment in any proposal, eg /shipments/sid/65577, and click Add Container
  • Create a puck, checking that barcode is not a required field
  • Create a plate (eg container type of CrystalQuickX), try to leave the barcode field blank, check you get an error
  • Try a barcode that already exists (eg "a"), check you get a sensible error message
  • Try a unique barcode, check you can create the plate (no samples are needed)

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.1 September 2, 2025 10:06
@ndg63276 ndg63276 merged commit 6e07305 into pre-release/2025-R4.1 Sep 2, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1804/make-barcode-required-for-plates branch September 2, 2025 10:08
ndg63276 added a commit that referenced this pull request Sep 16, 2025
* LIMS-1856: Fix offset for plates (#973)

* LIMS-1839: Fix fast_dp radiation damage plots (#964)

* LIMS-1814: Add min images filter to summary page (#966)

* LIMS-1804: Make barcode be required for new plates (#969)

* LIMS-1802: Improvements to Add Shipment page (#972)

* LIMS-1784: Add drawing for Cryo EM Puck (#970)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants