Skip to content

LIMS-1807: Leave 'Mark Dispensing' button active until cancelled#967

Merged
ndg63276 merged 2 commits intopre-release/2025-R4.2from
improvement/LIMS-1807/leave-mark-dispensing-button-active
Sep 16, 2025
Merged

LIMS-1807: Leave 'Mark Dispensing' button active until cancelled#967
ndg63276 merged 2 commits intopre-release/2025-R4.2from
improvement/LIMS-1807/leave-mark-dispensing-button-active

Conversation

@ndg63276
Copy link
Copy Markdown
Collaborator

JIRA ticket: LIMS-1807

Summary:

To make it easier to mark lots of wells, the 'Mark Dispensing' button should stay active until explicitly cancelled.

Changes:

  • Remove trigger and listener when a dispensing point has been marked
  • Change 'Cancel' button to 'Finish' to match the Mark Point and Mark Region button equivalents

To test:

  • Go to /admin/imaging, then click on a container with some subsamples
  • Go to a well with subsamples, there will probably be a dispensing point marked already (or maybe several)
  • Click 'Mark Dispensing', check the button changes to 'Finish' (and there is also a 'Delete' button)
  • Click somewhere on the image. Check the (most recent) dispensing point moves to where you clicked.
  • Check the buttons still say 'Finish' and 'Delete'. Move the dispensing point again and check it still moves.
  • Go to a different well with subsamples, check the mark dispensing is still active, so you can quickly go from well to well and mark the dispensing point in each.
  • Check the 'Finish' button works as expected, and that clicking on the image no longer marks the dispensing point.

@gfrn
Copy link
Copy Markdown
Collaborator

gfrn commented Aug 14, 2025

I couldn't test it locally, as for some reason the dispensing locations always reset themselves when I select a new one. I'll try deploying to dev-6 when I can, because I can't do that at the moment either

@ndg63276 ndg63276 changed the base branch from master to pre-release/2025-R4.2 September 16, 2025 09:58
@ndg63276 ndg63276 merged commit b84a0d7 into pre-release/2025-R4.2 Sep 16, 2025
2 checks passed
@ndg63276 ndg63276 deleted the improvement/LIMS-1807/leave-mark-dispensing-button-active branch September 16, 2025 09:59
ndg63276 added a commit that referenced this pull request Sep 30, 2025
* LIMS-1844: Update archiving messages for 'il' proposals (#977)

* LIMS-1807: Leave 'Mark Dispensing' button active until cancelled (#967)

* LIMS-1799: Checks for safety level should be case insensitive (#955)

* LIMS-1786: Add Dewars column to Shipments page (#958)

* LIMS-1426: Allow setting of pipeline when ranking samples (#950)

* LIMS-1783: Add parent container dropdown for gridboxes (#965)

* LIMS-1903: Fix display of shipping labels (#984)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants